Skip to content

Catbird Java API#24

Open
Alexander-Ignition wants to merge 3 commits into
masterfrom
feature/java_api
Open

Catbird Java API#24
Alexander-Ignition wants to merge 3 commits into
masterfrom
feature/java_api

Conversation

@Alexander-Ignition

@Alexander-Ignition Alexander-Ignition commented Jul 28, 2020

Copy link
Copy Markdown
Collaborator

Java API for QA engineers. They write UI tests using Apium, Maven and Java

Comment thread catbird-api/src/main/java/com/redmadrobot/catbird/api/PatternMatch.java Outdated
Comment thread catbird-api/src/main/java/com/redmadrobot/catbird/api/PatternMatch.java Outdated
@vani2 vani2 requested a review from Fi5t July 31, 2020 13:17

@Fi5t Fi5t left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you don't need to use Java at all =) Why not a Kotlin?

Comment thread catbird-api/pom.xml Outdated
Comment thread catbird-api/src/main/java/com/redmadrobot/catbird/api/Catbird.java Outdated
Comment thread catbird-api/src/main/java/com/redmadrobot/catbird/api/Catbird.java Outdated
Comment thread catbird-api/src/main/java/com/redmadrobot/catbird/api/Catbird.java Outdated
Comment thread catbird-api/src/main/java/com/redmadrobot/catbird/api/Catbird.java Outdated
Comment thread catbird-api/src/main/java/com/redmadrobot/catbird/api/Catbird.java Outdated
Comment thread catbird-api/src/main/java/com/redmadrobot/catbird/api/Catbird.java Outdated
Comment thread catbird-api/src/main/java/com/redmadrobot/catbird/api/Catbird.java Outdated
Comment thread catbird-api/src/main/java/com/redmadrobot/catbird/api/Catbird.java Outdated
Comment thread catbird-api/src/main/java/com/redmadrobot/catbird/api/CatbirdAction.java Outdated
@Alexander-Ignition

Copy link
Copy Markdown
Collaborator Author

I think you don't need to use Java at all =) Why not a Kotlin?

This code is written for use by QA engineers. They write UI tests using Apium, Maven and Java

@Fi5t

Fi5t commented Jul 31, 2020

Copy link
Copy Markdown

I think you don't need to use Java at all =) Why not a Kotlin?

This code is written for use by QA engineers. They write UI tests using Apium, Maven and Java

Ok, but Kotlin has complete binary compatibility with Java and good interop with it. I recommend considering Kotlin as alternative. By the way, you can don't use Java because of this nice interop.

I've a few more comments to this code, but I decided to start ask you to replace Java to Kotlin :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants